Client/server
5
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor(statistics): simplify server ranking data construction in QueryServerTotalDataLogic

Browse Source
This commit is contained in:
Chang lue Tsen 2025-09-04 15:21:07 -04:00
parent e8d3ebba68
commit e913f974bb
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/logic/admin/console/queryServerTotalDataLogic.go
View File

@ -104,19 +104,19 @@ func (l *QueryServerTotalDataLogic) QueryServerTotalData() (resp *types.ServerTo
return nil, errors.Wrapf(xerr.NewErrCode(xerr.DatabaseQueryError), " Query server traffic failed: %v", err.Error()) return nil, errors.Wrapf(xerr.NewErrCode(xerr.DatabaseQueryError), " Query server traffic failed: %v", err.Error())
} }
todayServerRanking := make([]types.ServerTrafficData, len(todayTop10Server)) var todayServerRanking []types.ServerTrafficData
for i, item := range todayTop10Server { for _, item := range todayTop10Server {
info, err := l.svcCtx.NodeModel.FindOneServer(l.ctx, item.ServerId) info, err := l.svcCtx.NodeModel.FindOneServer(l.ctx, item.ServerId)
if err != nil { if err != nil {
l.Errorw("[QueryServerTotalDataLogic] FindOneServer error", logger.Field("error", err.Error()), logger.Field("server_id", item.ServerId)) l.Errorw("[QueryServerTotalDataLogic] FindOneServer error", logger.Field("error", err.Error()), logger.Field("server_id", item.ServerId))
continue continue
} }
todayServerRanking[i] = types.ServerTrafficData{ todayServerRanking = append(todayServerRanking, types.ServerTrafficData{
ServerId: item.ServerId, ServerId: item.ServerId,
Name: info.Name, Name: info.Name,
Upload: item.Upload, Upload: item.Upload,
Download: item.Download, Download: item.Download,
} })
} }
// query server traffic rank yesterday // query server traffic rank yesterday
@ -133,19 +133,18 @@ func (l *QueryServerTotalDataLogic) QueryServerTotalData() (resp *types.ServerTo
if err != nil { if err != nil {
l.Errorw("[QueryServerTotalDataLogic] Unmarshal yesterday server traffic rank log error", logger.Field("error", err.Error())) l.Errorw("[QueryServerTotalDataLogic] Unmarshal yesterday server traffic rank log error", logger.Field("error", err.Error()))
} }
yesterdayTop10Server = make([]types.ServerTrafficData, len(rank.Rank)) for _, v := range rank.Rank {
for i, v := range rank.Rank {
info, err := l.svcCtx.NodeModel.FindOneServer(l.ctx, v.ServerId) info, err := l.svcCtx.NodeModel.FindOneServer(l.ctx, v.ServerId)
if err != nil { if err != nil {
l.Errorw("[QueryServerTotalDataLogic] FindOneServer error", logger.Field("error", err.Error()), logger.Field("server_id", v.ServerId)) l.Errorw("[QueryServerTotalDataLogic] FindOneServer error", logger.Field("error", err.Error()), logger.Field("server_id", v.ServerId))
continue continue
} }
yesterdayTop10Server[i] = types.ServerTrafficData{ yesterdayTop10Server = append(yesterdayTop10Server, types.ServerTrafficData{
ServerId: v.ServerId, ServerId: v.ServerId,
Name: info.Name, Name: info.Name,
Upload: v.Upload, Upload: v.Upload,
Download: v.Download, Download: v.Download,
} })
} }
} }