From 0690debf6c1bab7472468c742f9b15639f904c20 Mon Sep 17 00:00:00 2001
From: "web@ppanel" <web@ppanel.dev>
Date: Mon, 29 Dec 2025 09:02:02 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix:=20Refactor=20update=20dialo?=
 =?UTF-8?q?g=20logic=20in=20SystemVersionCard=20for=20better=20clarity=20a?=
 =?UTF-8?q?nd=20handling=20of=20update=20states?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../components/system-version-card.tsx        | 198 +++++++++---------
 1 file changed, 100 insertions(+), 98 deletions(-)

diff --git a/apps/admin/src/sections/dashboard/components/system-version-card.tsx b/apps/admin/src/sections/dashboard/components/system-version-card.tsx
index 4a8cfe2..0b1e527 100644
--- a/apps/admin/src/sections/dashboard/components/system-version-card.tsx
+++ b/apps/admin/src/sections/dashboard/components/system-version-card.tsx
@@ -80,6 +80,7 @@ export default function SystemVersionCard() {
     staleTime: 0,
     retry: 1,
   });
+  console.log(webVersionInfo);
 
   const updateServerMutation = useMutation({
     mutationFn: async (serviceName: string) => {
@@ -188,52 +189,52 @@ export default function SystemVersionCard() {
           </div>
           <div className="flex items-center space-x-2">
             <Badge>V{packageJson.version}</Badge>
-            {hasWebNewVersion && webVersionInfo && (
-              <AlertDialog onOpenChange={setOpenUpdateWeb} open={openUpdateWeb}>
-                <AlertDialogTrigger asChild>
-                  <Button
-                    className="h-6 px-2 text-xs"
-                    disabled={isUpdatingWeb}
-                    size="sm"
-                    variant="outline"
-                  >
-                    <Icon className="mr-1 h-3 w-3" icon="mdi:download" />
-                    {t("update", "Update")} V{webVersionInfo.latest_version}
+            <AlertDialog onOpenChange={setOpenUpdateWeb} open={openUpdateWeb}>
+              <AlertDialogTrigger asChild>
+                <Button
+                  className="h-6 px-2 text-xs"
+                  disabled={!hasWebNewVersion || isUpdatingWeb}
+                  size="sm"
+                  variant="outline"
+                >
+                  <Icon className="mr-1 h-3 w-3" icon="mdi:download" />
+                  {hasWebNewVersion && webVersionInfo
+                    ? `${t("update", "Update")} V${webVersionInfo.latest_version}`
+                    : t("update", "Update")}
+                </Button>
+              </AlertDialogTrigger>
+              <AlertDialogContent>
+                <AlertDialogHeader>
+                  <AlertDialogTitle>
+                    {t("confirmUpdate", "Confirm Update")}
+                  </AlertDialogTitle>
+                  <AlertDialogDescription>
+                    {webVersionInfo
+                      ? t(
+                          "updateWebDescription",
+                          "Are you sure you want to update the web version from V{{current}} to V{{latest}}?",
+                          {
+                            current: packageJson.version,
+                            latest: webVersionInfo.latest_version,
+                          }
+                        )
+                      : t(
+                          "updateDescription",
+                          "Are you sure you want to update?"
+                        )}
+                  </AlertDialogDescription>
+                </AlertDialogHeader>
+                <AlertDialogFooter>
+                  <AlertDialogCancel>{t("cancel", "Cancel")}</AlertDialogCancel>
+                  <Button disabled={isUpdatingWeb} onClick={handleUpdateWeb}>
+                    {isUpdatingWeb && (
+                      <Icon className="mr-2 animate-spin" icon="mdi:loading" />
+                    )}
+                    {t("confirmUpdate", "Confirm Update")}
                   </Button>
-                </AlertDialogTrigger>
-                <AlertDialogContent>
-                  <AlertDialogHeader>
-                    <AlertDialogTitle>
-                      {t("confirmUpdate", "Confirm Update")}
-                    </AlertDialogTitle>
-                    <AlertDialogDescription>
-                      {t(
-                        "updateWebDescription",
-                        "Are you sure you want to update the web version from V{{current}} to V{{latest}}?",
-                        {
-                          current: packageJson.version,
-                          latest: webVersionInfo.latest_version,
-                        }
-                      )}
-                    </AlertDialogDescription>
-                  </AlertDialogHeader>
-                  <AlertDialogFooter>
-                    <AlertDialogCancel>
-                      {t("cancel", "Cancel")}
-                    </AlertDialogCancel>
-                    <Button disabled={isUpdatingWeb} onClick={handleUpdateWeb}>
-                      {isUpdatingWeb && (
-                        <Icon
-                          className="mr-2 animate-spin"
-                          icon="mdi:loading"
-                        />
-                      )}
-                      {t("confirmUpdate", "Confirm Update")}
-                    </Button>
-                  </AlertDialogFooter>
-                </AlertDialogContent>
-              </AlertDialog>
-            )}
+                </AlertDialogFooter>
+              </AlertDialogContent>
+            </AlertDialog>
           </div>
         </div>
 
@@ -251,62 +252,63 @@ export default function SystemVersionCard() {
                 serverVersionInfo?.current_version ||
                 "1.0.0"}
             </Badge>
-            {hasServerNewVersion && serverVersionInfo && moduleConfig && (
-              <AlertDialog
-                onOpenChange={setOpenUpdateServer}
-                open={openUpdateServer}
-              >
-                <AlertDialogTrigger asChild>
+            <AlertDialog
+              onOpenChange={setOpenUpdateServer}
+              open={openUpdateServer}
+            >
+              <AlertDialogTrigger asChild>
+                <Button
+                  className="h-6 px-2 text-xs"
+                  disabled={!hasServerNewVersion || isUpdatingServer}
+                  size="sm"
+                  variant="outline"
+                >
+                  <Icon className="mr-1 h-3 w-3" icon="mdi:download" />
+                  {hasServerNewVersion && serverVersionInfo
+                    ? `${t("update", "Update")} ${serverVersionInfo.latest_version}`
+                    : t("update", "Update")}
+                </Button>
+              </AlertDialogTrigger>
+              <AlertDialogContent>
+                <AlertDialogHeader>
+                  <AlertDialogTitle>
+                    {t("confirmUpdate", "Confirm Update")}
+                  </AlertDialogTitle>
+                  <AlertDialogDescription>
+                    {serverVersionInfo && moduleConfig
+                      ? t(
+                          "updateServerDescription",
+                          "Are you sure you want to update the server version from V{{current}} to V{{latest}}?",
+                          {
+                            current:
+                              moduleConfig.service_version ||
+                              serverVersionInfo.current_version,
+                            latest: serverVersionInfo.latest_version,
+                          }
+                        )
+                      : t(
+                          "updateDescription",
+                          "Are you sure you want to update?"
+                        )}
+                  </AlertDialogDescription>
+                </AlertDialogHeader>
+                <AlertDialogFooter>
+                  <AlertDialogCancel>{t("cancel", "Cancel")}</AlertDialogCancel>
                   <Button
-                    className="h-6 px-2 text-xs"
-                    disabled={isUpdatingServer}
-                    size="sm"
-                    variant="outline"
+                    disabled={isUpdatingServer || !moduleConfig}
+                    onClick={() =>
+                      moduleConfig &&
+                      updateServerMutation.mutate(moduleConfig.service_name)
+                    }
                   >
-                    <Icon className="mr-1 h-3 w-3" icon="mdi:download" />
-                    {t("update", "Update")} V{serverVersionInfo.latest_version}
+                    {isUpdatingServer && (
+                      <Icon className="mr-2 animate-spin" icon="mdi:loading" />
+                    )}
+                    {t("confirmUpdate", "Confirm Update")}
                   </Button>
-                </AlertDialogTrigger>
-                <AlertDialogContent>
-                  <AlertDialogHeader>
-                    <AlertDialogTitle>
-                      {t("confirmUpdate", "Confirm Update")}
-                    </AlertDialogTitle>
-                    <AlertDialogDescription>
-                      {t(
-                        "updateServerDescription",
-                        "Are you sure you want to update the server version from V{{current}} to V{{latest}}?",
-                        {
-                          current:
-                            moduleConfig.service_version ||
-                            serverVersionInfo.current_version,
-                          latest: serverVersionInfo.latest_version,
-                        }
-                      )}
-                    </AlertDialogDescription>
-                  </AlertDialogHeader>
-                  <AlertDialogFooter>
-                    <AlertDialogCancel>
-                      {t("cancel", "Cancel")}
-                    </AlertDialogCancel>
-                    <Button
-                      disabled={isUpdatingServer}
-                      onClick={() =>
-                        updateServerMutation.mutate(moduleConfig.service_name)
-                      }
-                    >
-                      {isUpdatingServer && (
-                        <Icon
-                          className="mr-2 animate-spin"
-                          icon="mdi:loading"
-                        />
-                      )}
-                      {t("confirmUpdate", "Confirm Update")}
-                    </Button>
-                  </AlertDialogFooter>
-                </AlertDialogContent>
-              </AlertDialog>
-            )}
+                </AlertDialogFooter>
+              </AlertDialogContent>
+            </AlertDialog>
           </div>
         </div>
       </CardContent>