HI-VPN/hi-server
4
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

修复(#49): 修复清空备注时数据丢失 — RefererId 改为指针类型

Browse Source 
Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
shanshanzhong
2026-05-26 08:35:45 -07:00
parent f7f890c990
commit 27f1203282
4 changed files with 84 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apis/admin/user.api
+14 -14
View File
@@ -38,20 +38,20 @@ type (
Id int64 `form:"id" validate:"required"` Id int64 `form:"id" validate:"required"`
} }
UpdateUserBasiceInfoRequest { UpdateUserBasiceInfoRequest {
UserId int64 `json:"user_id" validate:"required"` UserId int64 `json:"user_id" validate:"required"`
Password string `json:"password"` Password string `json:"password"`
Avatar string `json:"avatar"` Avatar string `json:"avatar"`
Balance int64 `json:"balance"` Balance *int64 `json:"balance"`
Commission int64 `json:"commission"` Commission *int64 `json:"commission"`
ReferralPercentage uint8 `json:"referral_percentage"` ReferralPercentage uint8 `json:"referral_percentage"`
OnlyFirstPurchase *bool `json:"only_first_purchase"` OnlyFirstPurchase *bool `json:"only_first_purchase"`
GiftAmount int64 `json:"gift_amount"` GiftAmount *int64 `json:"gift_amount"`
Telegram int64 `json:"telegram"` Telegram int64 `json:"telegram"`
ReferCode string `json:"refer_code"` ReferCode string `json:"refer_code"`
RefererId int64 `json:"referer_id"` RefererId *int64 `json:"referer_id"`
Enable *bool `json:"enable"` Enable *bool `json:"enable"`
IsAdmin *bool `json:"is_admin"` IsAdmin *bool `json:"is_admin"`
Remark string `json:"remark"` Remark *string `json:"remark"`
} }
UpdateUserNotifySettingRequest { UpdateUserNotifySettingRequest {
UserId int64 `json:"user_id" validate:"required"` UserId int64 `json:"user_id" validate:"required"`
internal/logic/admin/user/updateUserBasicInfoLogic.go
+21 -17
View File
@@ -46,13 +46,13 @@ func (l *UpdateUserBasicInfoLogic) UpdateUserBasicInfo(req *types.UpdateUserBasi
} }
err = l.svcCtx.UserModel.Transaction(l.ctx, func(tx *gorm.DB) error { err = l.svcCtx.UserModel.Transaction(l.ctx, func(tx *gorm.DB) error {
if userInfo.Balance != req.Balance { if req.Balance != nil && userInfo.Balance != *req.Balance {
change := req.Balance - userInfo.Balance change := *req.Balance - userInfo.Balance
balanceLog := log.Balance{ balanceLog := log.Balance{
Type: log.BalanceTypeAdjust, Type: log.BalanceTypeAdjust,
Amount: change, Amount: change,
OrderNo: "", OrderNo: "",
Balance: req.Balance, Balance: *req.Balance,
Timestamp: time.Now().UnixMilli(), Timestamp: time.Now().UnixMilli(),
} }
content, _ := balanceLog.Marshal() content, _ := balanceLog.Marshal()
@@ -66,14 +66,14 @@ func (l *UpdateUserBasicInfoLogic) UpdateUserBasicInfo(req *types.UpdateUserBasi
if err != nil { if err != nil {
return err return err
} }
userInfo.Balance = req.Balance userInfo.Balance = *req.Balance
} }
if userInfo.GiftAmount != req.GiftAmount { if req.GiftAmount != nil && userInfo.GiftAmount != *req.GiftAmount {
change := req.GiftAmount - userInfo.GiftAmount change := *req.GiftAmount - userInfo.GiftAmount
if change != 0 { if change != 0 {
var changeType uint16 var changeType uint16
if userInfo.GiftAmount < req.GiftAmount { if userInfo.GiftAmount < *req.GiftAmount {
changeType = log.GiftTypeIncrease changeType = log.GiftTypeIncrease
} else { } else {
changeType = log.GiftTypeReduce changeType = log.GiftTypeReduce
@@ -81,7 +81,7 @@ func (l *UpdateUserBasicInfoLogic) UpdateUserBasicInfo(req *types.UpdateUserBasi
giftLog := log.Gift{ giftLog := log.Gift{
Type: changeType, Type: changeType,
Amount: change, Amount: change,
Balance: req.GiftAmount, Balance: *req.GiftAmount,
Remark: "Admin adjustment", Remark: "Admin adjustment",
Timestamp: time.Now().UnixMilli(), Timestamp: time.Now().UnixMilli(),
} }
@@ -96,23 +96,27 @@ func (l *UpdateUserBasicInfoLogic) UpdateUserBasicInfo(req *types.UpdateUserBasi
if err != nil { if err != nil {
return err return err
} }
userInfo.GiftAmount = req.GiftAmount userInfo.GiftAmount = *req.GiftAmount
} }
} }
if req.Commission != userInfo.Commission { if req.Commission != nil && *req.Commission != userInfo.Commission {
if isWithdrawalScene(req.Remark) { remark := ""
if req.Remark != nil {
remark = *req.Remark
}
if isWithdrawalScene(remark) {
logWithdrawalGuard(l.Logger, userInfo.Id) logWithdrawalGuard(l.Logger, userInfo.Id)
return errors.Wrapf(xerr.NewErrCode(xerr.InvalidAccess), "commission overwrite is blocked in withdrawal scene") return errors.Wrapf(xerr.NewErrCode(xerr.InvalidAccess), "commission overwrite is blocked in withdrawal scene")
} }
change := req.Commission - userInfo.Commission change := *req.Commission - userInfo.Commission
if err = l.svcCtx.UserModel.UpdateCommission(l.ctx, userInfo.Id, change, tx); err != nil { if err = l.svcCtx.UserModel.UpdateCommission(l.ctx, userInfo.Id, change, tx); err != nil {
return err return err
} }
if err = logicCommon.WriteCommissionLog(tx, userInfo.Id, log.CommissionTypeAdjust, change, ""); err != nil { if err = logicCommon.WriteCommissionLog(tx, userInfo.Id, log.CommissionTypeAdjust, change, ""); err != nil {
return err return err
} }
userInfo.Commission = req.Commission userInfo.Commission = *req.Commission
} }
if req.Avatar != "" { if req.Avatar != "" {
userInfo.Avatar = req.Avatar userInfo.Avatar = req.Avatar
@@ -120,8 +124,8 @@ func (l *UpdateUserBasicInfoLogic) UpdateUserBasicInfo(req *types.UpdateUserBasi
if req.ReferCode != "" { if req.ReferCode != "" {
userInfo.ReferCode = req.ReferCode userInfo.ReferCode = req.ReferCode
} }
if req.RefererId != 0 { if req.RefererId != nil {
userInfo.RefererId = req.RefererId userInfo.RefererId = *req.RefererId
} }
if req.Enable != nil { if req.Enable != nil {
userInfo.Enable = req.Enable userInfo.Enable = req.Enable
@@ -129,8 +133,8 @@ func (l *UpdateUserBasicInfoLogic) UpdateUserBasicInfo(req *types.UpdateUserBasi
if req.IsAdmin != nil { if req.IsAdmin != nil {
userInfo.IsAdmin = req.IsAdmin userInfo.IsAdmin = req.IsAdmin
} }
if req.Remark != "" { if req.Remark != nil {
userInfo.Remark = req.Remark userInfo.Remark = *req.Remark
} }
if req.OnlyFirstPurchase != nil { if req.OnlyFirstPurchase != nil {
userInfo.OnlyFirstPurchase = req.OnlyFirstPurchase userInfo.OnlyFirstPurchase = req.OnlyFirstPurchase
internal/types/types.go
+14 -14
View File
@@ -3264,20 +3264,20 @@ type UpdateUserAuthMethodRequest struct {
} }
type UpdateUserBasiceInfoRequest struct { type UpdateUserBasiceInfoRequest struct {
UserId int64 `json:"user_id" validate:"required"` UserId int64 `json:"user_id" validate:"required"`
Password string `json:"password"` Password string `json:"password"`
Avatar string `json:"avatar"` Avatar string `json:"avatar"`
Balance int64 `json:"balance"` Balance *int64 `json:"balance"`
Commission int64 `json:"commission"` Commission *int64 `json:"commission"`
ReferralPercentage uint8 `json:"referral_percentage"` ReferralPercentage uint8 `json:"referral_percentage"`
OnlyFirstPurchase *bool `json:"only_first_purchase"` OnlyFirstPurchase *bool `json:"only_first_purchase"`
GiftAmount int64 `json:"gift_amount"` GiftAmount *int64 `json:"gift_amount"`
Telegram int64 `json:"telegram"` Telegram int64 `json:"telegram"`
ReferCode string `json:"refer_code"` ReferCode string `json:"refer_code"`
RefererId int64 `json:"referer_id"` RefererId *int64 `json:"referer_id"`
Enable *bool `json:"enable"` Enable *bool `json:"enable"`
IsAdmin *bool `json:"is_admin"` IsAdmin *bool `json:"is_admin"`
Remark string `json:"remark"` Remark *string `json:"remark"`
} }
type UpdateUserNotifyRequest struct { type UpdateUserNotifyRequest struct {
internal/types/update_user_basic_info_request_test.go
+35
View File
@@ -0,0 +1,35 @@
package types
import (
"encoding/json"
"testing"
)
func TestUpdateUserBasicInfoRequestRemarkPresence(t *testing.T) {
var omitted UpdateUserBasiceInfoRequest
if err := json.Unmarshal([]byte(`{"user_id":1}`), &omitted); err != nil {
t.Fatalf("unmarshal omitted remark: %v", err)
}
if omitted.Remark != nil {
t.Fatalf("omitted remark = %q, want nil", *omitted.Remark)
}
var cleared UpdateUserBasiceInfoRequest
if err := json.Unmarshal([]byte(`{"user_id":1,"remark":""}`), &cleared); err != nil {
t.Fatalf("unmarshal empty remark: %v", err)
}
if cleared.Remark == nil {
t.Fatal("empty remark was decoded as nil, want explicit empty string")
}
if *cleared.Remark != "" {
t.Fatalf("empty remark = %q, want empty string", *cleared.Remark)
}
var updated UpdateUserBasiceInfoRequest
if err := json.Unmarshal([]byte(`{"user_id":1,"remark":"new note"}`), &updated); err != nil {
t.Fatalf("unmarshal non-empty remark: %v", err)
}
if updated.Remark == nil || *updated.Remark != "new note" {
t.Fatalf("non-empty remark = %#v, want %q", updated.Remark, "new note")
}
}