refactor(auth): 调整代码格式和注释以提高可读性
All checks were successful
Build docker and publish / build (20.15.1) (push) Successful in 7m20s
All checks were successful
Build docker and publish / build (20.15.1) (push) Successful in 7m20s
style(user): 统一代码缩进和注释格式 fix(user): 修改设备冲突处理逻辑为更新归属而非删除 refactor(user): 移除不必要的用户删除逻辑和缓存清理
This commit is contained in:
parent
9d52826555
commit
e6bd78aa76
@ -24,6 +24,7 @@ type BindDeviceLogic struct {
|
||||
// 参数:
|
||||
// - ctx: 请求上下文,用于传递请求信息和控制超时
|
||||
// - svcCtx: 服务上下文,包含数据库连接、配置等依赖
|
||||
//
|
||||
// 返回:
|
||||
// - *BindDeviceLogic: 设备绑定逻辑处理器实例
|
||||
func NewBindDeviceLogic(ctx context.Context, svcCtx *svc.ServiceContext) *BindDeviceLogic {
|
||||
@ -226,6 +227,7 @@ func (l *BindDeviceLogic) createDeviceForUser(identifier, ip, userAgent string,
|
||||
// 1. 如果原用户是"纯设备用户"(只有设备认证,无邮箱等其他认证方式):
|
||||
// - 执行完整数据迁移(订单、订阅、余额、赠送金额)
|
||||
// - 禁用原用户账户
|
||||
//
|
||||
// 2. 如果原用户有其他认证方式(如邮箱、手机等):
|
||||
// - 只转移设备绑定关系
|
||||
// - 保留原用户账户和数据
|
||||
|
||||
@ -119,7 +119,8 @@ func (l *BindEmailWithVerificationLogic) transferDeviceToEmailUser(deviceUserId,
|
||||
logger.Field("email_user_id", emailUserId),
|
||||
logger.Field("device_identifier", deviceIdentifier))
|
||||
|
||||
// 1. 先获取当前用户的SessionId,用于后续清理
|
||||
// 1. 先获取当前用户的SessionId,用于后续清理 可以不需要
|
||||
|
||||
currentSessionId := ""
|
||||
if sessionIdValue := l.ctx.Value(constant.CtxKeySessionID); sessionIdValue != nil {
|
||||
currentSessionId = sessionIdValue.(string)
|
||||
@ -191,11 +192,11 @@ func (l *BindEmailWithVerificationLogic) transferDeviceToEmailUser(deviceUserId,
|
||||
return nil
|
||||
}
|
||||
|
||||
// 6. 处理设备冲突 - 删除目标用户的现有设备记录(如果存在)
|
||||
// 6. 处理设备冲突 - 将现有设备记录的归属修改为邮箱用户
|
||||
if existingDevice != nil && existingDevice.UserId != emailUserId {
|
||||
l.Infow("删除冲突的设备记录", logger.Field("existing_device_id", existingDevice.Id), logger.Field("existing_user_id", existingDevice.UserId))
|
||||
if err := db.Where("identifier = ? AND user_id = ?", deviceIdentifier, existingDevice.UserId).Delete(&user.Device{}).Error; err != nil {
|
||||
l.Errorw("删除冲突设备记录失败", logger.Field("error", err.Error()))
|
||||
l.Infow("更新冲突设备记录的归属", logger.Field("existing_device_id", existingDevice.Id), logger.Field("old_user_id", existingDevice.UserId), logger.Field("new_user_id", emailUserId))
|
||||
if err := db.Model(&user.Device{}).Where("identifier = ? AND user_id = ?", deviceIdentifier, existingDevice.UserId).Update("user_id", emailUserId).Error; err != nil {
|
||||
l.Errorw("更新冲突设备记录归属失败", logger.Field("error", err.Error()))
|
||||
return err
|
||||
}
|
||||
}
|
||||
@ -216,35 +217,6 @@ func (l *BindEmailWithVerificationLogic) transferDeviceToEmailUser(deviceUserId,
|
||||
return err
|
||||
}
|
||||
|
||||
// 9. 检查原始设备用户是否还有其他认证方式,如果没有则删除该用户
|
||||
var remainingAuthMethods []user.AuthMethods
|
||||
if err := db.Where("user_id = ?", deviceUserId).Find(&remainingAuthMethods).Error; err != nil {
|
||||
l.Errorw("查询原始用户剩余认证方式失败", logger.Field("error", err.Error()), logger.Field("device_user_id", deviceUserId))
|
||||
return err
|
||||
}
|
||||
|
||||
if len(remainingAuthMethods) == 0 {
|
||||
// 获取原始用户信息用于清除缓存
|
||||
deviceUser, _ := l.svcCtx.UserModel.FindOne(l.ctx, deviceUserId)
|
||||
|
||||
// 原始用户没有其他认证方式,可以安全删除
|
||||
if err := db.Where("id = ?", deviceUserId).Delete(&user.User{}).Error; err != nil {
|
||||
l.Errorw("删除原始设备用户失败", logger.Field("error", err.Error()), logger.Field("device_user_id", deviceUserId))
|
||||
return err
|
||||
}
|
||||
|
||||
// 清除已删除用户的缓存
|
||||
if deviceUser != nil {
|
||||
l.svcCtx.UserModel.ClearUserCache(l.ctx, deviceUser)
|
||||
}
|
||||
|
||||
l.Infow("已删除原始设备用户", logger.Field("device_user_id", deviceUserId))
|
||||
} else {
|
||||
l.Infow("原始用户还有其他认证方式,保留用户记录",
|
||||
logger.Field("device_user_id", deviceUserId),
|
||||
logger.Field("remaining_auth_count", len(remainingAuthMethods)))
|
||||
}
|
||||
|
||||
l.Infow("设备转移成功",
|
||||
logger.Field("device_user_id", deviceUserId),
|
||||
logger.Field("email_user_id", emailUserId),
|
||||
@ -284,7 +256,7 @@ func (l *BindEmailWithVerificationLogic) transferDeviceToEmailUser(deviceUserId,
|
||||
}
|
||||
|
||||
// 6. 清除设备相关缓存
|
||||
l.clearDeviceRelatedCache(deviceIdentifier, deviceUserId, emailUserId)
|
||||
// l.clearDeviceRelatedCache(deviceIdentifier, deviceUserId, emailUserId)
|
||||
|
||||
return &types.BindEmailWithVerificationResponse{
|
||||
Success: true,
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user