7236ca4cf2
此前 calculatePurchasePrice 把 allowPromo 绑死在 orderType == 1,导致只要用户
有任何过往付费订阅(含已过期),就会被 paidSubscriptionQuery 路由为续费
(orderType=2),跳过所有促销评估。后果:
- InactiveUser 召回促销永远无法触发(其目标人群恰好就是有过期订阅的用户)
- Campaign 全员活动对老用户 / 升级加购场景完全失效
- 套餐列表(loadSubscribePromoMap)直接调 EvaluatePromo 不感知 orderType,
可能显示促销价但下单时却拿到原价
修复方式:把 isFirstPurchase 下放给 EvaluatePromo,由规则类型决定 gating:
- NewUser 要求 isFirstPurchase=true(保留首购语义)
- InactiveUser 由规则自身的"上次订阅过期 N 月以上"条件判定
- Campaign 时间窗内对任意用户生效
新增 common.HasPaidSubscription 助手,套餐列表与下单走同一份 isFirstPurchase
判定,确保展示价与实际下单价口径一致。
测试:补充 EvaluatePromo / calculatePurchasePrice 的 NewUser 屏蔽 + Campaign
放开用例;更新 loadSubscribePromoMap 测试覆盖新增 HasPaidSubscription 查询。
注:renewalLogic.go 仍未接入促销(属于方向 B 的彻底统一,本次未涵盖)。
196 lines
5.0 KiB
Go
196 lines
5.0 KiB
Go
package common
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/perfect-panel/server/internal/model/promo"
|
|
"github.com/perfect-panel/server/internal/svc"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
func TestEvaluateInactiveUserExpire(t *testing.T) {
|
|
now := time.Date(2026, 5, 27, 8, 0, 0, 0, time.UTC)
|
|
params := promoRuleParams{InactiveMonths: 3}
|
|
|
|
tests := []struct {
|
|
name string
|
|
lastExpire time.Time
|
|
want bool
|
|
}{
|
|
{
|
|
name: "permanent subscription is not inactive",
|
|
lastExpire: time.UnixMilli(0),
|
|
want: false,
|
|
},
|
|
{
|
|
name: "active subscription is not inactive",
|
|
lastExpire: now.Add(time.Hour),
|
|
want: false,
|
|
},
|
|
{
|
|
name: "expire at threshold is inactive",
|
|
lastExpire: now.AddDate(0, -3, 0),
|
|
want: true,
|
|
},
|
|
{
|
|
name: "expire before threshold is inactive",
|
|
lastExpire: now.AddDate(0, -3, -1),
|
|
want: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if got := evaluateInactiveUserExpire(tt.lastExpire, params, now); got != tt.want {
|
|
t.Fatalf("evaluateInactiveUserExpire() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestEvaluatePromoAllowsAnonymousCampaign(t *testing.T) {
|
|
end := time.Now().Add(time.Hour)
|
|
model := &fakePromoModel{rules: []*promo.RuleWithPrice{
|
|
{
|
|
Rule: promo.Rule{
|
|
Id: 3,
|
|
Name: "campaign",
|
|
Type: promo.RuleTypeCampaign,
|
|
Enabled: true,
|
|
EndTime: &end,
|
|
},
|
|
PromoPrice: 199,
|
|
},
|
|
}}
|
|
|
|
got, err := EvaluatePromo(context.Background(), &svc.ServiceContext{DB: &gorm.DB{}, PromoModel: model}, 0, 7, 12, true)
|
|
if err != nil {
|
|
t.Fatalf("EvaluatePromo returned error: %v", err)
|
|
}
|
|
if !got.Eligible {
|
|
t.Fatal("anonymous campaign promo should be eligible")
|
|
}
|
|
if got.RuleID != 3 {
|
|
t.Fatalf("RuleID = %d, want 3", got.RuleID)
|
|
}
|
|
if got.PromoPrice != 199 {
|
|
t.Fatalf("PromoPrice = %d, want 199", got.PromoPrice)
|
|
}
|
|
if model.lastSubscribeID != 7 {
|
|
t.Fatalf("lastSubscribeID = %d, want 7", model.lastSubscribeID)
|
|
}
|
|
if model.lastQuantity != 12 {
|
|
t.Fatalf("lastQuantity = %d, want 12", model.lastQuantity)
|
|
}
|
|
}
|
|
|
|
func TestEvaluatePromoCampaignAppliesToReturningUsers(t *testing.T) {
|
|
model := &fakePromoModel{rules: []*promo.RuleWithPrice{
|
|
{
|
|
Rule: promo.Rule{
|
|
Id: 4,
|
|
Name: "campaign",
|
|
Type: promo.RuleTypeCampaign,
|
|
Enabled: true,
|
|
},
|
|
PromoPrice: 299,
|
|
},
|
|
}}
|
|
|
|
got, err := EvaluatePromo(context.Background(), &svc.ServiceContext{DB: &gorm.DB{}, PromoModel: model}, 42, 7, 1, false)
|
|
if err != nil {
|
|
t.Fatalf("EvaluatePromo returned error: %v", err)
|
|
}
|
|
if !got.Eligible {
|
|
t.Fatal("campaign promo should remain eligible for returning users (isFirstPurchase=false)")
|
|
}
|
|
if got.PromoPrice != 299 {
|
|
t.Fatalf("PromoPrice = %d, want 299", got.PromoPrice)
|
|
}
|
|
}
|
|
|
|
func TestEvaluatePromoNewUserRequiresFirstPurchase(t *testing.T) {
|
|
model := &fakePromoModel{rules: []*promo.RuleWithPrice{
|
|
{
|
|
Rule: promo.Rule{
|
|
Id: 5,
|
|
Name: "new user",
|
|
Type: promo.RuleTypeNewUser,
|
|
Enabled: true,
|
|
Params: `{"window_hours": 72}`,
|
|
},
|
|
PromoPrice: 99,
|
|
},
|
|
}}
|
|
|
|
got, err := EvaluatePromo(context.Background(), &svc.ServiceContext{DB: &gorm.DB{}, PromoModel: model}, 42, 7, 1, false)
|
|
if err != nil {
|
|
t.Fatalf("EvaluatePromo returned error: %v", err)
|
|
}
|
|
if got.Eligible {
|
|
t.Fatal("new-user promo must be gated out when isFirstPurchase=false (user already has paid subscriptions)")
|
|
}
|
|
}
|
|
|
|
type fakePromoModel struct {
|
|
rules []*promo.RuleWithPrice
|
|
lastSubscribeID int64
|
|
lastQuantity int64
|
|
}
|
|
|
|
func (m *fakePromoModel) QueryEligibleRules(_ context.Context, subscribeID int64, quantity int64) ([]*promo.RuleWithPrice, error) {
|
|
m.lastSubscribeID = subscribeID
|
|
m.lastQuantity = quantity
|
|
return m.rules, nil
|
|
}
|
|
|
|
func (m *fakePromoModel) InsertUsage(context.Context, *promo.Usage, ...*gorm.DB) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakePromoModel) InsertRule(context.Context, *promo.Rule) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakePromoModel) FindRule(context.Context, int64) (*promo.Rule, error) {
|
|
return nil, gorm.ErrRecordNotFound
|
|
}
|
|
|
|
func (m *fakePromoModel) UpdateRule(context.Context, *promo.Rule) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakePromoModel) DeleteRule(context.Context, int64) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakePromoModel) QueryRuleList(context.Context, int, int, string, *bool, string) (int64, []*promo.Rule, error) {
|
|
return 0, nil, nil
|
|
}
|
|
|
|
func (m *fakePromoModel) UpsertPrices(context.Context, int64, []*promo.SubscribePromo) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakePromoModel) FindPrice(context.Context, int64) (*promo.SubscribePromo, error) {
|
|
return nil, gorm.ErrRecordNotFound
|
|
}
|
|
|
|
func (m *fakePromoModel) DeletePrice(context.Context, int64) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakePromoModel) QueryPriceList(context.Context, promo.PriceFilter) (int64, []*promo.SubscribePromo, error) {
|
|
return 0, nil, nil
|
|
}
|
|
|
|
func (m *fakePromoModel) QueryUsageList(context.Context, promo.UsageFilter) (int64, []*promo.Usage, error) {
|
|
return 0, nil, nil
|
|
}
|
|
|
|
func (m *fakePromoModel) Transaction(context.Context, func(*gorm.DB) error) error {
|
|
return nil
|
|
}
|