shanshanzhong147
7236ca4cf2
此前 calculatePurchasePrice 把 allowPromo 绑死在 orderType == 1，导致只要用户
有任何过往付费订阅（含已过期），就会被 paidSubscriptionQuery 路由为续费
（orderType=2），跳过所有促销评估。后果：
- InactiveUser 召回促销永远无法触发（其目标人群恰好就是有过期订阅的用户）
- Campaign 全员活动对老用户 / 升级加购场景完全失效
- 套餐列表（loadSubscribePromoMap）直接调 EvaluatePromo 不感知 orderType，
可能显示促销价但下单时却拿到原价
修复方式：把 isFirstPurchase 下放给 EvaluatePromo，由规则类型决定 gating：
- NewUser 要求 isFirstPurchase=true（保留首购语义）
- InactiveUser 由规则自身的"上次订阅过期 N 月以上"条件判定
- Campaign 时间窗内对任意用户生效
新增 common.HasPaidSubscription 助手，套餐列表与下单走同一份 isFirstPurchase
判定，确保展示价与实际下单价口径一致。
测试：补充 EvaluatePromo / calculatePurchasePrice 的 NewUser 屏蔽 + Campaign
放开用例；更新 loadSubscribePromoMap 测试覆盖新增 HasPaidSubscription 查询。
注：renewalLogic.go 仍未接入促销（属于方向 B 的彻底统一，本次未涵盖）。
264 lines
8.6 KiB
Go
264 lines
8.6 KiB
Go
package subscribe
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/DATA-DOG/go-sqlmock"
|
|
"github.com/perfect-panel/server/internal/model/promo"
|
|
"github.com/perfect-panel/server/internal/model/user"
|
|
"github.com/perfect-panel/server/internal/svc"
|
|
"github.com/perfect-panel/server/internal/types"
|
|
"github.com/perfect-panel/server/pkg/constant"
|
|
"gorm.io/driver/mysql"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
func TestQuerySubscribePromoCandidatesIncludesQuantity(t *testing.T) {
|
|
db, err := gorm.Open(mysql.New(mysql.Config{
|
|
DSN: "gorm:gorm@tcp(localhost:9910)/gorm?charset=utf8&parseTime=True&loc=Local",
|
|
SkipInitializeWithVersion: true,
|
|
}), &gorm.Config{DryRun: true, DisableAutomaticPing: true})
|
|
if err != nil {
|
|
t.Fatalf("open dry-run db: %v", err)
|
|
}
|
|
|
|
var candidates []subscribePromoCandidate
|
|
tx := subscribePromoCandidatesQuery(context.Background(), db, []int64{11, 12}, true).Scan(&candidates)
|
|
stmt := tx.Statement
|
|
sql := stmt.SQL.String()
|
|
if !strings.Contains(sql, "sp.subscribe_id, sp.quantity, sp.promo_price") {
|
|
t.Fatalf("SQL missing quantity select: %s", sql)
|
|
}
|
|
if !strings.Contains(sql, "ORDER BY sp.subscribe_id ASC,sp.quantity ASC,pr.priority DESC,pr.id ASC") {
|
|
t.Fatalf("SQL missing quantity order: %s", sql)
|
|
}
|
|
}
|
|
|
|
func TestLoadSubscribePromoMapUsesCommonPromoEvaluation(t *testing.T) {
|
|
db, mock, cleanup := newSubscribePromoTestDB(t)
|
|
defer cleanup()
|
|
|
|
end := time.Now().Add(time.Hour)
|
|
mock.ExpectQuery("FROM subscribe_promo AS sp").
|
|
WillReturnRows(sqlmock.NewRows([]string{
|
|
"subscribe_id", "quantity", "rule_name", "rule_type", "promo_price", "params", "start_time", "end_time",
|
|
}).AddRow(11, 3, "old name", promoRuleTypeCampaign, 999, "", nil, end))
|
|
|
|
promoModel := &fakeSubscribePromoModel{rules: []*promo.RuleWithPrice{
|
|
{
|
|
Rule: promo.Rule{
|
|
Id: 8,
|
|
Name: "公共活动价",
|
|
Type: promo.RuleTypeCampaign,
|
|
Enabled: true,
|
|
EndTime: &end,
|
|
},
|
|
PromoPrice: 888,
|
|
},
|
|
}}
|
|
|
|
got, err := loadSubscribePromoMap(context.Background(), &svc.ServiceContext{DB: db, PromoModel: promoModel}, []int64{11})
|
|
if err != nil {
|
|
t.Fatalf("loadSubscribePromoMap returned error: %v", err)
|
|
}
|
|
if err := mock.ExpectationsWereMet(); err != nil {
|
|
t.Fatalf("sql expectations: %v", err)
|
|
}
|
|
if promoModel.lastSubscribeID != 11 {
|
|
t.Fatalf("promo subscribe id = %d, want 11", promoModel.lastSubscribeID)
|
|
}
|
|
if promoModel.lastQuantity != 3 {
|
|
t.Fatalf("promo quantity = %d, want 3", promoModel.lastQuantity)
|
|
}
|
|
|
|
item := got[11][3]
|
|
if item == nil {
|
|
t.Fatal("quantity 3 promo should be present")
|
|
}
|
|
if item.RuleName != "公共活动价" {
|
|
t.Fatalf("RuleName = %q, want 公共活动价", item.RuleName)
|
|
}
|
|
if item.PromoPrice != 888 {
|
|
t.Fatalf("PromoPrice = %d, want 888", item.PromoPrice)
|
|
}
|
|
if item.ExpiresAt != end.Unix() {
|
|
t.Fatalf("ExpiresAt = %d, want %d", item.ExpiresAt, end.Unix())
|
|
}
|
|
}
|
|
|
|
func TestLoadSubscribePromoMapUsesFamilyOwnerForInactivePromo(t *testing.T) {
|
|
db, mock, cleanup := newSubscribePromoTestDB(t)
|
|
defer cleanup()
|
|
|
|
memberUserID := int64(51637)
|
|
ownerUserID := int64(510)
|
|
subscribeID := int64(11)
|
|
quantity := int64(30)
|
|
now := time.Now()
|
|
end := now.Add(24 * time.Hour)
|
|
|
|
mock.ExpectQuery("FROM `user_family_member`").
|
|
WithArgs(memberUserID, user.FamilyMemberActive, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"role", "family_status", "owner_user_id"}).
|
|
AddRow(user.FamilyRoleMember, user.FamilyStatusActive, ownerUserID))
|
|
mock.ExpectQuery("SELECT count(*) FROM `user_subscribe`").
|
|
WithArgs(ownerUserID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"count"}).AddRow(0))
|
|
mock.ExpectQuery("FROM subscribe_promo AS sp").
|
|
WillReturnRows(sqlmock.NewRows([]string{
|
|
"subscribe_id", "quantity", "rule_name", "rule_type", "promo_price", "params", "start_time", "end_time",
|
|
}).AddRow(subscribeID, quantity, "回归用户01", promoRuleTypeInactiveUser, 100, `{"inactive_months":1}`, nil, end))
|
|
mock.ExpectQuery("FROM `user_subscribe`").
|
|
WithArgs(ownerUserID, time.UnixMilli(0), 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "user_id", "subscribe_id", "expire_time"}).
|
|
AddRow(131, ownerUserID, 1, now.AddDate(0, 1, 0)))
|
|
|
|
ctx := context.WithValue(context.Background(), constant.CtxKeyUser, &user.User{Id: memberUserID})
|
|
promoModel := &fakeSubscribePromoModel{rules: []*promo.RuleWithPrice{
|
|
{
|
|
Rule: promo.Rule{
|
|
Id: 8,
|
|
Name: "回归用户01",
|
|
Type: promo.RuleTypeInactiveUser,
|
|
Enabled: true,
|
|
Params: `{"inactive_months":1}`,
|
|
EndTime: &end,
|
|
},
|
|
PromoPrice: 100,
|
|
},
|
|
}}
|
|
|
|
got, err := loadSubscribePromoMap(ctx, &svc.ServiceContext{DB: db, PromoModel: promoModel}, []int64{subscribeID})
|
|
if err != nil {
|
|
t.Fatalf("loadSubscribePromoMap returned error: %v", err)
|
|
}
|
|
if err := mock.ExpectationsWereMet(); err != nil {
|
|
t.Fatalf("sql expectations: %v", err)
|
|
}
|
|
if promoModel.lastSubscribeID != subscribeID {
|
|
t.Fatalf("promo subscribe id = %d, want %d", promoModel.lastSubscribeID, subscribeID)
|
|
}
|
|
if promoModel.lastQuantity != quantity {
|
|
t.Fatalf("promo quantity = %d, want %d", promoModel.lastQuantity, quantity)
|
|
}
|
|
if got[subscribeID][quantity] != nil {
|
|
t.Fatalf("family member should not receive inactive promo when owner has active subscription, got %+v", got[subscribeID][quantity])
|
|
}
|
|
}
|
|
|
|
type fakeSubscribePromoModel struct {
|
|
rules []*promo.RuleWithPrice
|
|
lastSubscribeID int64
|
|
lastQuantity int64
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) QueryEligibleRules(_ context.Context, subscribeID int64, quantity int64) ([]*promo.RuleWithPrice, error) {
|
|
m.lastSubscribeID = subscribeID
|
|
m.lastQuantity = quantity
|
|
return m.rules, nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) InsertUsage(context.Context, *promo.Usage, ...*gorm.DB) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) InsertRule(context.Context, *promo.Rule) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) FindRule(context.Context, int64) (*promo.Rule, error) {
|
|
return nil, gorm.ErrRecordNotFound
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) UpdateRule(context.Context, *promo.Rule) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) DeleteRule(context.Context, int64) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) QueryRuleList(context.Context, int, int, string, *bool, string) (int64, []*promo.Rule, error) {
|
|
return 0, nil, nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) UpsertPrices(context.Context, int64, []*promo.SubscribePromo) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) FindPrice(context.Context, int64) (*promo.SubscribePromo, error) {
|
|
return nil, gorm.ErrRecordNotFound
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) DeletePrice(context.Context, int64) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) QueryPriceList(context.Context, promo.PriceFilter) (int64, []*promo.SubscribePromo, error) {
|
|
return 0, nil, nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) QueryUsageList(context.Context, promo.UsageFilter) (int64, []*promo.Usage, error) {
|
|
return 0, nil, nil
|
|
}
|
|
|
|
func (m *fakeSubscribePromoModel) Transaction(context.Context, func(*gorm.DB) error) error {
|
|
return nil
|
|
}
|
|
|
|
func newSubscribePromoTestDB(t *testing.T) (*gorm.DB, sqlmock.Sqlmock, func()) {
|
|
t.Helper()
|
|
|
|
sqlDB, mock, err := sqlmock.New(sqlmock.QueryMatcherOption(sqlmock.QueryMatcherFunc(func(expectedSQL, actualSQL string) error {
|
|
if strings.Contains(actualSQL, expectedSQL) {
|
|
return nil
|
|
}
|
|
return fmt.Errorf("actual sql %q does not contain %q", actualSQL, expectedSQL)
|
|
})))
|
|
if err != nil {
|
|
t.Fatalf("create sqlmock: %v", err)
|
|
}
|
|
|
|
db, err := gorm.Open(mysql.New(mysql.Config{Conn: sqlDB, SkipInitializeWithVersion: true}), &gorm.Config{})
|
|
if err != nil {
|
|
_ = sqlDB.Close()
|
|
t.Fatalf("open gorm db: %v", err)
|
|
}
|
|
|
|
return db, mock, func() {
|
|
_ = sqlDB.Close()
|
|
}
|
|
}
|
|
|
|
func TestApplySubscribeDiscountPromosMatchesQuantity(t *testing.T) {
|
|
subscribe := types.Subscribe{Discount: []types.SubscribeDiscount{
|
|
{Quantity: 1},
|
|
{Quantity: 12},
|
|
}}
|
|
promos := map[int64]*types.SubscribePromo{
|
|
3: {RuleName: "季度优惠", PromoPrice: 2900},
|
|
12: {RuleName: "年度优惠", PromoPrice: 9900},
|
|
}
|
|
|
|
applySubscribeDiscountPromos(&subscribe, promos)
|
|
if subscribe.Discount[0].Promo != nil {
|
|
t.Fatalf("quantity 1 promo should be nil, got %+v", subscribe.Discount[0].Promo)
|
|
}
|
|
if subscribe.Discount[1].Promo == nil {
|
|
t.Fatal("quantity 12 promo should match")
|
|
}
|
|
if got, want := subscribe.Discount[1].Promo.RuleName, "年度优惠"; got != want {
|
|
t.Fatalf("promo rule name = %q, want %q", got, want)
|
|
}
|
|
|
|
subscribe = types.Subscribe{Discount: []types.SubscribeDiscount{{Quantity: 6}}}
|
|
applySubscribeDiscountPromos(&subscribe, promos)
|
|
if subscribe.Discount[0].Promo != nil {
|
|
t.Fatalf("promo should be nil when quantity does not match, got %+v", subscribe.Discount[0].Promo)
|
|
}
|
|
}
|